Skip to content

fix: configure TLS for ratelimit in gateway namespace mode#5973

Closed
cnvergence wants to merge 3 commits intoenvoyproxy:mainfrom
cnvergence:rate-limit-gtw-mode
Closed

fix: configure TLS for ratelimit in gateway namespace mode#5973
cnvergence wants to merge 3 commits intoenvoyproxy:mainfrom
cnvergence:rate-limit-gtw-mode

Conversation

@cnvergence
Copy link
Member

@cnvergence cnvergence commented May 9, 2025

What type of PR is this?

What this PR does / why we need it:

Configure sTLS for ratelimit in gateway namespace mode

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence requested a review from a team as a code owner May 9, 2025 13:12
@cnvergence cnvergence requested review from zhaohuabing and zirain May 9, 2025 13:12
@arkodg
Copy link
Contributor

arkodg commented May 9, 2025

RL-EG should run in mTLS mode even for Gateway namespace mode

@cnvergence cnvergence marked this pull request as draft May 9, 2025 15:03
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.82%. Comparing base (e4b68b3) to head (bd99987).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5973      +/-   ##
==========================================
+ Coverage   65.80%   65.82%   +0.01%     
==========================================
  Files         217      217              
  Lines       36056    36060       +4     
==========================================
+ Hits        23728    23737       +9     
+ Misses      10854    10849       -5     
  Partials     1474     1474              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence changed the title fix: configure sTLS for ratelimit in gateway namespace mode fix: configure TLS for ratelimit in gateway namespace mode May 10, 2025
@zhaohuabing
Copy link
Member

Try to fix this with #5988

@cnvergence cnvergence closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants